Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal DB changes #247

Merged
merged 5 commits into from
Dec 2, 2023
Merged

Internal DB changes #247

merged 5 commits into from
Dec 2, 2023

Conversation

monstermunchkin
Copy link
Member

  • internal/server/db: Remove function doDbScan
  • internal/server: Use Retry function
  • internal/server/db: Unwrap dbQueryRowScan function
  • internal/server/db: Unwrap queryScan function
  • internal/server/db: Remove exec function

@stgraber
Copy link
Member

@monstermunchkin tests look unhappy

@monstermunchkin
internal/server/db: Remove function doDbScan
b2f2141 
This removes the `doDbScan` function in favor of `queryScan`.

Signed-off-by: Thomas Hipp <[email protected]>
@monstermunchkin
internal/server: Use Retry function
6b5d14e 
This removes the now obsolete `Cluster.retry` function in favor of
`query.Retry`. This function also gains a context argument.

Signed-off-by: Thomas Hipp <[email protected]>
@monstermunchkin
internal/server/db: Unwrap dbQueryRowScan function
7ed5f3a 
This unwraps the `dbQueryRowScan` function. It no longer depends on a
Cluster struct but instead takes a pointer to a ClusterTx struct. It
also gains a context parameter.

Signed-off-by: Thomas Hipp <[email protected]>
@monstermunchkin
internal/server/db: Unwrap queryScan function
bbcee43 
This unwraps the `queryScan` function. It no longer depends on a Cluster
struct but instead takes a pointer to a ClusterTx struct. It also gains
a context parameter.

Signed-off-by: Thomas Hipp <[email protected]>
@monstermunchkin
internal/server/db: Remove exec function
539eb22 
This removes the `exec` function in favor of `tx.ExecContext`.

Signed-off-by: Thomas Hipp <[email protected]>
@monstermunchkin
Copy link
Member Author

@stgraber good to go.

@stgraber stgraber merged commit 4343f13 into lxc:main Dec 2, 2023
25 checks passed
@stgraber
Copy link
Member

stgraber commented Dec 2, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stgraber stgraber stgraber approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@monstermunchkin @stgraber